Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` #9668

jesswrd · 2025-07-23T18:19:35Z

Merged hardcoded compileSdkVersion instead of using flutter.compileSdkVersion. Reverting back to flutter.compileSdkVersion.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

flutter-dashboard · 2025-07-23T18:19:37Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request correctly reverts a hardcoded compileSdkVersion in the camera_android plugin's build.gradle file, replacing it with the flutter.compileSdkVersion variable. This is the correct approach, ensuring the plugin respects the SDK version of the consuming Flutter application, which improves compatibility and maintainability. The change is sound and aligns with best practices for Flutter plugin development. I have no further comments.

script/tool/lib/src/gradle_check_command.dart

jesswrd · 2025-07-23T21:52:52Z

script/tool/lib/src/gradle_check_command.dart

      }
    }
+    if (!compileSdkLine.contains('flutter.compileSdkVersion') && minFlutterVersion! >= Version(3, 27, 0)) {
+      printError('${indentation}Please use flutter.compileSdkVersion instead '


Suggested change

printError('${indentation}Please use flutter.compileSdkVersion instead '

printError('${indentation}Warning: please use flutter.compileSdkVersion instead '

A useful warning requires some sort of message at the bottom of the gradle_check_command output. Will probably have to look in package_looping_command.

Per my comment in the other PR, a message at the bottom of the output still won't really be a useful warning most of the time. We have printWarning, which will cause a message in the summary at the end, but as it says in its docs:

/// Warnings are not surfaced in CI summaries, so this is only useful for /// highlighting something when someone is already looking though the log /// messages. DO NOT RELY on someone noticing a warning; instead, use it for /// things that might be useful to someone debugging an unexpected result.

Taking this over--how about we keep the printError and just return false? The validation will fail then they can look through the logs to see the reason why.

Some context got lost here; this thread in the original PR explains the problem with making it an error to use a value.

Understood. I added a check for lower that flutter.compileSdkVersion. Of course, that isn't great because it relies on a hard coded version of that value and not the actual value itself, so we would have to update the command every time flutter.compileSdkVersion is used, so more maintenance burden. But, I'm okay keeping it.

Also, I considered adding a check for version == flutter.compileSdkVersion but I don't think that's a major value add, but let me know if you disagree.

packages/camera/camera_android/android/build.gradle

stuartmorgan-g · 2025-07-24T13:28:12Z

script/tool/lib/src/gradle_check_command.dart

      }
    }
+    if (!compileSdkLine.contains('flutter.compileSdkVersion') && minFlutterVersion! >= Version(3, 27, 0)) {
+      printError('${indentation}Please use flutter.compileSdkVersion instead '


Per my comment in the other PR, a message at the bottom of the output still won't really be a useful warning most of the time. We have printWarning, which will cause a message in the summary at the end, but as it says in its docs:

/// Warnings are not surfaced in CI summaries, so this is only useful for /// highlighting something when someone is already looking though the log /// messages. DO NOT RELY on someone noticing a warning; instead, use it for /// things that might be useful to someone debugging an unexpected result.

stuartmorgan-g · 2025-08-19T18:31:13Z

From triage: What's the status of this PR? We still want to fix this, right?

script/tool/lib/src/gradle_check_command.dart

stuartmorgan-g · 2025-09-24T13:48:02Z

script/tool/lib/src/gradle_check_command.dart

      }
    }
+    if (!compileSdkLine.contains('flutter.compileSdkVersion') && minFlutterVersion! >= Version(3, 27, 0)) {
+      printError('${indentation}Please use flutter.compileSdkVersion instead '


Some context got lost here; this thread in the original PR explains the problem with making it an error to use a value.

stuartmorgan-g

LGTM

stuartmorgan-g · 2025-09-29T18:18:04Z

script/tool/lib/src/gradle_check_command.dart

        return false;
      }
+    } else {
+      // Extract compileSdkVersion and check if it higher than flutter.compileSdkVersion.


Typo: if it is

…ion` in `camera_android` (flutter/packages#9668)

flutter/packages@287739d...321a584 2025-09-30 [email protected] [local_auth] Adopt structured errors - platform interface (flutter/packages#10023) 2025-09-30 [email protected] Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` (flutter/packages#9668) 2025-09-30 [email protected] [file_selector] updates build files to use JVM 17 (flutter/packages#10097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

revert hardcoded compilesdk back to flutter.compileSdkVersion

4690dc4

jesswrd requested a review from camsim99 as a code owner July 23, 2025 18:19

github-actions bot added p: camera platform-android labels Jul 23, 2025

gemini-code-assist bot reviewed Jul 23, 2025

View reviewed changes

jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 23, 2025

added check for hardcoding compilesdk version number

f8f999c

jesswrd commented Jul 23, 2025

View reviewed changes

script/tool/lib/src/gradle_check_command.dart Outdated Show resolved Hide resolved

jesswrd commented Jul 23, 2025

View reviewed changes

stuartmorgan-g reviewed Jul 24, 2025

View reviewed changes

camsim99 added 2 commits September 22, 2025 14:37

Merge remote-tracking branch 'upstream/main' into use-compileSdkVersion

eb5f109

Bump version

1e12eec

camsim99 requested a review from stuartmorgan-g September 22, 2025 21:42

stuartmorgan-g reviewed Sep 24, 2025

View reviewed changes

camsim99 added 4 commits September 29, 2025 06:59

add check for below min flutter sdk version

72c63df

test for main message

2d83876

format

ef09abb

Merge remote-tracking branch 'upstream/main' into use-compileSdkVersion

139e5cd

camsim99 requested a review from stuartmorgan-g September 29, 2025 18:08

stuartmorgan-g approved these changes Sep 29, 2025

View reviewed changes

fix typo

459ef39

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

auto-submit bot merged commit 15acade into flutter:main Sep 30, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2025

15acade75 Revert hardcoded compilesdk back to `flutter.compileSdkVers…

e440637

…ion` in `camera_android` (flutter/packages#9668)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Packages from 287739d0acce to 321a5846838d (3 revisions) flutter/flutter#176357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` #9668

Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` #9668

jesswrd commented Jul 23, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

jesswrd Jul 23, 2025

Uh oh!

jesswrd Jul 23, 2025

Uh oh!

stuartmorgan-g Jul 24, 2025

Uh oh!

camsim99 Sep 22, 2025

Uh oh!

stuartmorgan-g Sep 24, 2025

Uh oh!

camsim99 Sep 29, 2025

Uh oh!

Uh oh!

stuartmorgan-g Jul 24, 2025

Uh oh!

stuartmorgan-g commented Aug 19, 2025

Uh oh!

Uh oh!

stuartmorgan-g Sep 24, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

	printError('${indentation}Please use flutter.compileSdkVersion instead '
	printError('${indentation}Warning: please use flutter.compileSdkVersion instead '

Revert hardcoded compilesdk back to flutter.compileSdkVersion in camera_android #9668

Revert hardcoded compilesdk back to flutter.compileSdkVersion in camera_android #9668

Conversation

jesswrd commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

flutter-dashboard bot commented Jul 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Aug 19, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` #9668

Revert hardcoded compilesdk back to `flutter.compileSdkVersion` in `camera_android` #9668

jesswrd commented Jul 23, 2025 •

edited

Loading